Update app.py

app.py

@@ -7,29 +7,34 @@ try:
 except Exception:
     HfApiModel = None
 
-# --------- Shared model factory with fallback + verbose errors ---------
+
+# --------- Model factory (latest-compatible) ----------
 def get_model(prefer_openai=True):
     """
-    Picks an LLM for the agent. Prefers OpenAI via LiteLLM if OPENAI_API_KEY is set,
-    falls back to Hugging Face Inference (HF_MODEL) otherwise.
+    Pick an LLM for the agent.
+    - Prefer OpenAI via LiteLLM if OPENAI_API_KEY is set.
+    - Else fall back to Hugging Face Inference (HF_MODEL).
+    NOTE: Temperature is set on the *model* in current smolagents.
     """
     last_error = None
     if prefer_openai and os.getenv("OPENAI_API_KEY"):
-        model_id = os.getenv("OPENAI_MODEL", "gpt-5")  # change if your account lacks access
+        model_id = os.getenv("OPENAI_MODEL", "gpt-4o-mini")  # safer default than gpt-5
         try:
             return LiteLLMModel(
                 model_id=model_id,
                 api_key=os.getenv("OPENAI_API_KEY"),
-                base_url=os.getenv("OPENAI_BASE_URL")
+                base_url=os.getenv("OPENAI_BASE_URL"),
+                temperature=0  # determinism for orchestration
             )
         except Exception as e:
             last_error = f"OpenAI model init failed for '{model_id}': {e}"
-            # Try a widely available fallback
+            # one more fallback attempt
             try:
                 return LiteLLMModel(
                     model_id="gpt-4o-mini",
                     api_key=os.getenv("OPENAI_API_KEY"),
-                    base_url=os.getenv("OPENAI_BASE_URL")
+                    base_url=os.getenv("OPENAI_BASE_URL"),
+                    temperature=0
                 )
             except Exception as e2:
                 last_error += f" | Fallback gpt-4o-mini failed: {e2}"
@@ -42,10 +47,15 @@ def get_model(prefer_openai=True):
 
     raise RuntimeError(last_error or "No model available. Set OPENAI_API_KEY or HF_MODEL in Space secrets.")
 
+
+# --------------- Diagnostics (OpenAI ping) ---------------
 def diag_openai_ping(prompt="Say 'pong' and nothing else."):
-    """Quick connectivity test to your OpenAI key/model."""
+    """
+    Quick connectivity test to your OpenAI key/model.
+    Newer smolagents: no system_prompt arg; put instructions in the goal text.
+    """
     try:
-        model = get_model(prefer_openai=True)  # force OpenAI path if possible
+        model = get_model(prefer_openai=True)
 
         @tool
         def echo_tool(x: str) -> str:
@@ -61,16 +71,17 @@ def diag_openai_ping(prompt="Say 'pong' and nothing else."):
             tools=[echo_tool],
             model=model,
             add_base_tools=False,
+            # no temperature or system_prompt here (unsupported on latest agent ctor)
         )
-        # Newer smolagents: put instructions inside the goal string
-        out = agent.run("Reply with the user message verbatim. No extra words.\nMessage: " + prompt)
+
+        goal = "Reply with the user message verbatim. No extra words.\nMessage: " + prompt
+        out = agent.run(goal)
         return f"✅ OpenAI ping ok.\nModel: {getattr(model, 'model_id', 'unknown')}\nOutput: {out}"
     except Exception:
         return "❌ OpenAI ping failed:\n" + traceback.format_exc()
 
-# =======================================
-# Exercise 1: Hello Tools (add + multiply)
-# =======================================
+
+# ===================== Exercise 1 =====================
 @tool
 def add(a: float, b: float) -> float:
     """Add two numbers.
@@ -110,9 +121,8 @@ def run_ex1():
     except Exception:
         return "❌ Exercise 1 error:\n" + traceback.format_exc()
 
-# =======================================
-# Exercise 2: Guardrails + fixed plan
-# =======================================
+
+# ===================== Exercise 2 =====================
 def run_ex2():
     try:
         agent = CodeAgent(
@@ -133,9 +143,8 @@ def run_ex2():
     except Exception:
         return "❌ Exercise 2 error:\n" + traceback.format_exc()
 
-# =======================================
-# Exercise 3: Mini PR -> PO
-# =======================================
+
+# ===================== Exercise 3 =====================
 @tool
 def validate_pr(pr: dict) -> dict:
     """Validate basic PR fields and structure.
@@ -188,8 +197,9 @@ DEFAULT_PR = json.dumps({
 }, indent=2)
 
 def run_ex3(pr_text):
+    # Validate JSON, then inline into goal (latest run() has no additional_context kw)
     try:
-        pr = json.loads(pr_text)
+        _ = json.loads(pr_text)
     except Exception as e:
         return f"Invalid JSON: {e}"
     try:
@@ -204,17 +214,21 @@ def run_ex3(pr_text):
             "1) validate_pr(pr). If ok==false, PRINT ONLY {\"error\": errors}.\n"
             "2) If ok==true, call create_po(pr).\n"
             "3) PRINT ONLY the resulting PO JSON. No extra text.\n"
-            "Task: Convert this PR to a PO (strict JSON). The PR is provided in additional_context['pr']."
+            "The PR object you must operate on is provided below as JSON. "
+            "Parse it into a Python dict variable named `pr` before calling tools.\n\n"
+            "PR JSON:\n```json\n" + pr_text + "\n```\n"
         )
-        out = agent.run(goal, additional_context={"pr": pr})
+        out = agent.run(goal)
         return str(out)
     except Exception:
         return "❌ Exercise 3 error:\n" + traceback.format_exc()
 
+
 # --------------------- Gradio UI ---------------------
 with gr.Blocks(title="Smolagents Beginner Lab (Online)") as demo:
     gr.Markdown("# Smolagents Beginner Lab (Online)")
-    gr.Markdown("Set `OPENAI_API_KEY` in Space secrets for best results. Optional: `OPENAI_MODEL` (e.g., gpt-5 or gpt-4o-mini).")
+    gr.Markdown("Set `OPENAI_API_KEY` in Space secrets (recommended). Optional: `OPENAI_MODEL` (e.g., gpt-4o-mini). "
+                "Fallback: set `HF_MODEL` (e.g., Qwen/Qwen2.5-7B-Instruct).")
 
     with gr.Tab("Diagnostics"):
         ping_btn = gr.Button("Run OpenAI ping test")