Update app.py

app.py

@@ -164,8 +164,10 @@ def update_ratings(state, winner_index, collection, category):
         winner = next(entry['original_model'] for entry in chatbots_data if entry['adapter'] == winner_adapter)
         loser = next(entry['original_model'] for entry in chatbots_data if entry['adapter'] == loser_adapter)
         
-        elo_ratings = update_elo_ratings(elo_ratings, winner_adapter, loser_adapter, category)
-        update_elo_rating(collection, elo_ratings, winner_adapter, loser_adapter, category)
+        if category != "overall":
+            elo_ratings = update_elo_ratings(elo_ratings, winner_adapter, loser_adapter, category)
+            update_elo_rating(collection, elo_ratings, winner_adapter, loser_adapter, category)
+        
         return [('Winner: ', winner), ('Loser: ', loser)]
     except Exception as e:
         print(f"Error updating ratings: {str(e)}")
@@ -177,17 +179,17 @@ async def vote_up_model(state, chatbot, chatbot2, character_name, character_desc
     # Disable both upvote buttons immediately
     yield chatbot, chatbot2, gr.Button.update(interactive=False, value="👍 Upvoted"), gr.Button.update(interactive=False), gr.Textbox.update(interactive=False), gr.Button.update(interactive=False)
     
+    # Update ratings and yield winner/loser immediately
+    update_message = update_ratings(state, 0, collection, "overall")
+    chatbot.append(update_message[0])
+    chatbot2.append(update_message[1])
+    yield chatbot, chatbot2, gr.Button.update(interactive=False, value="👍 Upvoted"), gr.Button.update(interactive=False), gr.Textbox.update(interactive=False), gr.Button.update(interactive=False)
+    
     # Process sentiment analysis asynchronously
-    sentiment_task = asyncio.create_task(classify_vote(user_input))
-    top_category = await sentiment_task
+    top_category = await classify_vote(user_input)
     
     if top_category:
-        update_message = update_ratings(state, 0, collection, top_category)
-        chatbot.append(update_message[0])
-        chatbot2.append(update_message[1])
-    
-    yield chatbot, chatbot2, gr.Button.update(interactive=False, value="👍 Upvoted"), gr.Button.update(interactive=False), gr.Textbox.update(interactive=False), gr.Button.update(interactive=False)
-    
+        update_ratings(state, 0, collection, top_category)
 async def vote_down_model(state, chatbot, chatbot2, character_name, character_description, user_name):
     user_input = format_prompt(state, 1, character_name, character_description, user_name)
     collection = init_database()
@@ -195,17 +197,17 @@ async def vote_down_model(state, chatbot, chatbot2, character_name, character_de
     # Disable both upvote buttons immediately
     yield chatbot, chatbot2, gr.Button.update(interactive=False), gr.Button.update(interactive=False, value="👍 Upvoted"), gr.Textbox.update(interactive=False), gr.Button.update(interactive=False)
     
+    # Update ratings and yield winner/loser immediately
+    update_message = update_ratings(state, 1, collection, "overall")
+    chatbot2.append(update_message[0])
+    chatbot.append(update_message[1])
+    yield chatbot, chatbot2, gr.Button.update(interactive=False), gr.Button.update(interactive=False, value="👍 Upvoted"), gr.Textbox.update(interactive=False), gr.Button.update(interactive=False)
+    
     # Process sentiment analysis asynchronously
-    sentiment_task = asyncio.create_task(classify_vote(user_input))
-    top_category = await sentiment_task
+    top_category = await classify_vote(user_input)
     
     if top_category:
-        update_message = update_ratings(state, 1, collection, top_category)
-        chatbot2.append(update_message[0])
-        chatbot.append(update_message[1])
-    
-    yield chatbot, chatbot2, gr.Button.update(interactive=False), gr.Button.update(interactive=False, value="👍 Upvoted"), gr.Textbox.update(interactive=False), gr.Button.update(interactive=False)
-    
+        update_ratings(state, 1, collection, top_category)
 async def user_ask(state, chatbot1, chatbot2, textbox, character_name, character_description, user_name):
     if character_name and len(character_name) > 20:
         character_name = character_name[:20]  # Limit character name to 20 characters